Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename my-app to app round 2 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions __test__/after-task.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ test('"after" task only prints summary in unattended mode', async t => {
here: false,
prompts,
run,
properties: {name: 'my-app'},
properties: {name: 'app'},
features: ['a', 'b'],
notDefaultFeatures: ['a', 'b-c'],
ansiColors
Expand All @@ -38,7 +38,7 @@ test('"after" task only prints summary in unattended mode', async t => {

t.is(printOut,
'\nGet Started\n' +
'cd my-app\n' +
'cd app\n' +
'npm install\n' +
'npm start\n\n'
);
Expand All @@ -61,7 +61,7 @@ test('"after" task only prints summary in unattended mode and here mode', async
here: true,
prompts,
run,
properties: {name: 'my-app'},
properties: {name: 'app'},
features: ['a', 'b'],
notDefaultFeatures: ['a', 'b-c'],
ansiColors
Expand Down Expand Up @@ -98,7 +98,7 @@ test('"after" task installs deps with npm, and prints summary', async t => {
here: false,
prompts,
run,
properties: {name: 'my-app'},
properties: {name: 'app'},
features: ['a', 'b'],
notDefaultFeatures: ['a', 'b-c'],
ansiColors
Expand All @@ -113,7 +113,7 @@ test('"after" task installs deps with npm, and prints summary', async t => {
'\nNext time, you can try to create similar project in silent mode:\n' +
' npx makes aurelia new-project-name -s a,b-c \n\n' +
'Get Started\n' +
'cd my-app\n' +
'cd app\n' +
'npm start\n\n'
);
});
Expand All @@ -137,7 +137,7 @@ test('"after" task installs deps with yarn, and prints summary', async t => {
here: false,
prompts,
run,
properties: {name: 'my-app'},
properties: {name: 'app'},
features: ['a', 'b'],
notDefaultFeatures: ['a', 'b-c'],
ansiColors
Expand All @@ -152,7 +152,7 @@ test('"after" task installs deps with yarn, and prints summary', async t => {
'\nNext time, you can try to create similar project in silent mode:\n' +
' npx makes aurelia new-project-name -s a,b-c \n\n' +
'Get Started\n' +
'cd my-app\n' +
'cd app\n' +
'yarn start\n\n'
);
});
Expand All @@ -176,7 +176,7 @@ test('"after" task installs deps with pnpm, and prints summary', async t => {
here: false,
prompts,
run,
properties: {name: 'my-app'},
properties: {name: 'app'},
features: ['a', 'b'],
notDefaultFeatures: ['a', 'b-c'],
ansiColors
Expand All @@ -191,7 +191,7 @@ test('"after" task installs deps with pnpm, and prints summary', async t => {
'\nNext time, you can try to create similar project in silent mode:\n' +
' npx makes aurelia new-project-name -s a,b-c \n\n' +
'Get Started\n' +
'cd my-app\n' +
'cd app\n' +
'pnpm start\n\n'
);
});
Expand All @@ -215,7 +215,7 @@ test('"after" task installs deps, and prints summary in here mode', async t => {
here: true,
prompts,
run,
properties: {name: 'my-app'},
properties: {name: 'app'},
features: ['a', 'b'],
notDefaultFeatures: ['a', 'b-c'],
ansiColors
Expand Down
4 changes: 2 additions & 2 deletions app-min/e2e__if_playwright/app.spec.ext__if_not_plugin
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ test.beforeEach(async ({ page }) => {
await page.goto('http://localhost:9000');
});

test.describe('MyApp', () => {
test.describe('App', () => {
test('shows message', async ({ page }) => {
await expect(page.locator('my-app div')).toHaveText('Hello World!');
await expect(page.locator('app div')).toHaveText('Hello World!');
});
});
2 changes: 1 addition & 1 deletion app-min/src/my-app.ext
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export class MyApp {
export class App {
/* @if typescript */public /* @endif */message = 'Hello World!';
}
6 changes: 3 additions & 3 deletions app-min/test__if_not_no-unit-tests/my-app.spec.ext
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import { expect } from 'chai';
import { CustomElement } from 'aurelia';
// @endif
import { render } from './helper';
import { MyApp } from '../src/my-app';
import { App } from '../src/app';

describe('my-app', () => {
describe('app', () => {
it('should render message', async () => {
const node = (await render('<my-app></my-app>', MyApp)).firstElementChild;
const node = (await render('<app></app>', App)).firstElementChild;
// @if shadow-dom
// In Shadow DOM open mode, shadowRoot is also accessible through DOM API
// node.shadowRoot
Expand Down
2 changes: 1 addition & 1 deletion app-with-router/src/my-app.ext
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export class MyApp {
export class App {
}
2 changes: 1 addition & 1 deletion common/README.md__skip-if-exists
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ import * as myPlugin from '/* @echo name */';
Aurelia
// Load all exports from the plugin
.register(myPlugin)
.app(MyApp)
.app(App)
.start();
```
// @endif
Expand Down
4 changes: 2 additions & 2 deletions common/src/main.ext__if_app
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Aurelia/* @if shadow-dom *//*, { StyleConfiguration }*//* @endif */ from
// @if app-with-router
import { RouterConfiguration } from '@aurelia/router';
// @endif
import { MyApp } from './my-app';
import { App } from './app';
// @if shadow-dom
// @if webpack
// Css files imported in this main file are NOT processed by style-loader
Expand All @@ -31,5 +31,5 @@ Aurelia
// customized router config.
// .register(RouterConfiguration.customize({ useUrlFragmentHash: false }))
// @endif
.app(MyApp)
.app(App)
.start();
2 changes: 1 addition & 1 deletion dumber/_index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</head>

<body>
<my-app></my-app>
<app></app>
<script src="/dist/entry.bundle.js" data-main="main"></script>
</body>

Expand Down
2 changes: 1 addition & 1 deletion parcel/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</head>

<body>
<my-app></my-app>
<app></app>
</body>

</html>
Expand Down
4 changes: 2 additions & 2 deletions plugin-min/dev-app/main.ext
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import 'promise-polyfill/lib/polyfill';
// @endif
import Aurelia/* @if shadow-dom *//*, { StyleConfiguration }*//* @endif */ from 'aurelia';
import { MyApp } from './my-app';
import { App } from './app';
// @if shadow-dom
// @if webpack
// Css files imported in this main file are NOT processed by style-loader
Expand All @@ -25,5 +25,5 @@ Aurelia
// @endif
// Register all exports of the plugin
.register(Plugin)
.app(MyApp)
.app(App)
.start();
2 changes: 1 addition & 1 deletion plugin-min/dev-app/my-app.ext
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export class MyApp {
export class App {
}
2 changes: 1 addition & 1 deletion webpack/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</head>

<body>
<my-app></my-app>
<app></app>
</body>

</html>