Update I18N documentation #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section about using `BaseI18N` was outdated: * `TCustomAttribute` already observes language change events and updates itself. * Base18N does not respect `t-params`, causing incorrect translations. See [issue 273 for details](aurelia#273 (comment))
zewa666
reviewed
Jun 6, 2018
| > Just remember in case you define your own `constructor`, to call `this.super` and pass it the instances of its | ||
| dependencies as described in the previous example. Same applies to `attached`, although nothing needs to be passed | ||
| in here | ||
| Use `i18n.updateTranslation()` to update all translations within the children of the element that is passed to it. |
There was a problem hiding this comment.
actually its i18n.updateTranslations()
|
I'm not sure whether it's good to simply remove the documentation about the BaseI18N class as it's currently in use. Instead we should show a deprecation notice and that this is going to be removed with the next major release. |
|
I thought removing it is the better option since there’s no need to use it anymore (even in the current release) and using it leads to translation errors. |
|
True, although in combination with what is mentioned here, it might not be that bad. Nevertheless would you mind just updating your PR with the above mentioned typo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section about using
BaseI18Nwas outdated:TCustomAttributealready observes language change events and updates itself.t-params, causing incorrect translations.See #273 for details.