fix(t-attribute): undefined and null bound values (#314)

if the provided value is bound to a null or undefined property the resulting value for translation should be an empty string fixes issue #313
aurelia · Feb 19, 2020 · 2a61ee7 · 2a61ee7
1 parent 0276f9c
commit 2a61ee7
Show file tree

Hide file tree

Showing 3 changed files with 70 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/i18n.ts b/src/i18n.ts
@@ -187,7 +187,7 @@ export class I18N {
 
   public updateValue(node: Element & { au: any }, value: string, params: any) {
     if (value === null || value === undefined) {
-      return;
+      value = "";
     }
 
     const keys = value.toString().split(";");

diff --git a/test/unit/t-attribute.spec.ts b/test/unit/t-attribute.spec.ts
@@ -26,4 +26,38 @@ describe("t-attribute", () => {
 
     component.dispose();
   });
+
+  it("should convert bound integers to strings", async () => {
+    const expectedValue = "";
+    const component = StageComponent
+      .withResources("mocks/rt-vm")
+      .inView(`<p t.bind="undef" id="undefined">
+        Undefined value
+      </p>
+      <p t.bind="nullul" id="null">
+        Null value
+      </p>
+      <p t.bind="zero" id="zero">
+        Zero value
+      </p>`)
+      .boundTo({
+        undef: undefined,
+        nullul: null,
+        zero: 0
+      });
+
+    bootstrapTestEnvironment(component, {
+      resources: {
+        en: { translation: { 1: expectedValue } }
+      }
+    });
+
+    await component.create(bootstrap);
+
+    expect(document.getElementById("undefined")!.innerHTML).toBe("");
+    expect(document.getElementById("null")!.innerHTML).toBe("");
+    expect(document.getElementById("zero")!.innerHTML).toBe("0");
+
+    component.dispose();
+  });
 });