Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root directory can now be specified #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Root directory can now be specified #4

wants to merge 1 commit into from

Conversation

taniwha3
Copy link
Collaborator

@taniwha3 taniwha3 commented Sep 27, 2022 •
edited
Loading

  • the root directory of authn can now be specified

@taniwha3 taniwha3 changed the title fix package names Root directory can now be specified Sep 27, 2022
dmah42
dmah42 reviewed Sep 27, 2022
View reviewed changes
authn/src/lib.rs
@@ -120,8 +121,7 @@ pub enum SomeError {
FailedToRunOpenssl,
}

fn generate_root_ca() -> Result<Vec<u8>, SomeError> {
let my_dir = env!("PWD");
fn generate_root_ca(my_dir: String) -> Result<Vec<u8>, SomeError> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a &str?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was getting lifetime issues and i don't quite understand them yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmah42 dmah42 dmah42 left review comments

Assignees
No one assigned
Labels
Access Granted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taniwha3 @dmah42