PSR-2 #1
Open
PSR-2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(formatterTest needs to be fixed)
|
Thanks for the PR. The code style and autoloader parts look good. Unfortunately however you have also changed some URLs and namespaces. Those changes I cannot merge into here, sorry. I you removed those changes from the PR, I can merge this. Thanks again. |
|
Wow, this PR goes back more than 6 Years. How time flies. I might look into what it was I wanted to achieve back then and might create a new fixed PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change method names, Braces, etc to PSR-2 standard. No functionality was changed.