Change examples/virtio to use new Makefile snippet system
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandermbrown
force-pushed
the
alexbr/improve-virtio-makefile
branch
from
f0daed1 to
1d38844
Compare
|
@wom-bat would you be able to have a look at this PR as well? |
wom-bat
requested changes
Jul 10, 2024
alexandermbrown
force-pushed
the
alexbr/improve-virtio-makefile
branch
from
5ca8f2d to
fadb281
Compare
|
This is ready for review again but we need to review/merge au-ts/sddf#152 before merging this one |
alexandermbrown
force-pushed
the
alexbr/improve-virtio-makefile
branch
from
b73b7c4 to
a85eae3
Compare
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Some snippets require LIBS to be defined such as sddf's network_components.mk. Without this, we get linking errors as microkit is not linked. Signed-off-by: Alex Brown <[email protected]>
alexandermbrown
force-pushed
the
alexbr/improve-virtio-makefile
branch
from
a85eae3 to
7b62f46
Compare
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
tools/linux/blk/blk_init.mk
Outdated
Comment on lines
7
to
9
| ifeq ($(strip $(LIBVMM)),) | ||
| $(error LIBVMM must be specified) | ||
| endif |
There was a problem hiding this comment.
Why not do LIBVMM ?= ../../?
There was a problem hiding this comment.
There was a problem hiding this comment.
You could do:
LINUX_BLK_DIR := $(abs $(dir $(last ${MAKEFILES_LIST}))
LIBVMM ?= $(realpath ${LINUX_BLK_DIR)}/../../)
There was a problem hiding this comment.
Done 282cad9
Signed-off-by: Alex Brown <[email protected]>
Without PRECIOUS, intermediate files (i.e., %_vm/*) are deleted Signed-off-by: Alex Brown <[email protected]>
Before make tried to delete directory `init.d`. Add file filter to find command to ensure we only delete dependency files. Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
vm.dts needs to depend on the CFLAGS as if the board is changed the dts files must be updated as well. Signed-off-by: Alex Brown <[email protected]>
wom-bat
requested changes
Jul 31, 2024
tools/linux/blk/blk_init.mk
Outdated
Comment on lines
7
to
9
| ifeq ($(strip $(LIBVMM)),) | ||
| $(error LIBVMM must be specified) | ||
| endif |
There was a problem hiding this comment.
You could do:
LINUX_BLK_DIR := $(abs $(dir $(last ${MAKEFILES_LIST}))
LIBVMM ?= $(realpath ${LINUX_BLK_DIR)}/../../)
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
|
I think all the feedback has been addressed now, can you squash the commits into one and then we can merge. |
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Signed-off-by: Alex Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #77 but for
examples/virtio.