Add SMC calls forwarding framework #21
Conversation
Added: - a framework for forwarding SMC calls to Secure Monitor, - SiP Service entry in the framework. Signed-off-by: Nataliya Korovkina <[email protected]>
|
Design note: smc.c file provided an SMC router Now there's the place in the file, separated by conditional compilation, to list handlers of Services that require "physical" access (vs. emulation) to EL3 components. At the moment, only SiP Service handler was declared. There's also common default service handler (unconditional forwarder) which can be assigned to be a handler for any of mentioned Services. Also, by default, the Service handlers are initialized with NULL in the library, so vmm application should explicitly pick the default handler or implement own one. |
src/arch/aarch64/smc.c
Outdated
| wheither a default handler that unconditionally forwards calls to Secure Monitor: | ||
|
|
||
| extern handle_service_type handle_xxx; | ||
| handle_service_type handle_xxx = default_handle_service; |
There was a problem hiding this comment.
In my opinion the user of the library should not have to do this, and instead just have a wrapper for setting the handler.
There was a problem hiding this comment.
Also thank you for writing comments for how to use the API.
There was a problem hiding this comment.
In my opinion the user of the library should not have to do this, and instead just have a wrapper for setting the handler.
Agreed, that would be easier to use.
src/arch/aarch64/smc.c
Outdated
| bool default_handle_service(uint64_t vcpu_id, seL4_UserContext *regs, uint64_t fn_number) | ||
| { | ||
|
|
||
| seL4_CPtr smc_cap = SMC_CAP; |
There was a problem hiding this comment.
While it isn't the current case for the rest of the library, I would like the library to be agnostic to the seL4 environment it is in, this means that it should be up to the user to provide the library with what capability to use for SMC calls.
If it's not too hard for you, it'd be good if specifying the SMC cap was part of the API.
There was a problem hiding this comment.
Right, good catch, I'll change it.
Added: - a framework for forwarding SMC calls to Secure Monitor, - SiP Service entry in the framework. Signed-off-by: Nataliya Korovkina <[email protected]>
|
Number of added names (functions, vars) somewhat noticeable (and may increase eventually over time), so I added prefixes |
src/arch/aarch64/smc.h
Outdated
| typedef bool (* smc_handle_service_type)(size_t, seL4_UserContext *, uint64_t); | ||
|
|
||
| /* Default handler of SiP service calls */ | ||
| bool smc_default_handle_sip(size_t vcpu_id, seL4_UserContext *regs, uint64_t fn_number); |
There was a problem hiding this comment.
This is no longer needed right?
Added:
- a framework for forwarding SMC calls to Secure Monitor,
- SiP Service entry in the framework.
Signed-off-by: Nataliya Korovkina <[email protected]>
|
Ping. Ping. |
Will get to it in the next couple days, thanks for the reminder. |
Well looks like a couple days turned into a couple months, sorry about that. I've made #119 which takes your changes and rebases, I made some minor changes as well. Thanks for the PR and I'll try be more responsive next time :) |
|
Thank you! |
Added: