packrootfs: add cpio installation status check #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, good spot. The problem is that this script does not have Can you add that to the script as well? |
Ivan-Velickovic
approved these changes
Dec 5, 2024
|
Actually can you put it below the license header? |
Signed-off-by: Bill Nguyen <[email protected]>
Signed-off-by: Bill Nguyen <[email protected]>
Signed-off-by: Bill Nguyen <[email protected]>
dreamliner787-9
force-pushed
the
packrootfs_fix
branch
from
15f6971 to
fe5427e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
packrootfsscript currently lacks a check for whethercpiois installed. Which leads to an insidious bug down the line where errors from unsuccessfully executingcpiodoes not bubble up from the subshell on line 100. So the script returns 0 and allow other build steps to continue even though the rootfs have not been repackaged correctly with the desired init script and user-level program.This manifests as the guest booting with the original rootfs instead of the repackaged one.
I've been able to reproduce this bug reliably on
bashandzsh.