Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value for failed VM exception callbacks #124

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix return value for failed VM exception callbacks #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/arch/aarch64/fault.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,14 +381,11 @@ static bool fault_handle_registered_vm_exceptions(size_t vcpu_id, uintptr_t addr
if (addr >= base && addr < end) {
bool success = callback(vcpu_id, addr - base, fsr, regs, data);
if (!success) {
// @ivanv: improve error message
LOG_VMM_ERR("registered virtual memory exception handler for region [0x%lx..0x%lx) at address 0x%lx failed\n", base,
end, addr);
}
/* Whether or not the callback actually successfully handled the
* exception, we return true to say that we at least found a handler
* for the faulting address. */
return true;

return success;
}
}

Expand Down
Loading