Cleanup vGIC fault handling code #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Velickovic
force-pushed
the
vgic_cleanup
branch
from
e636bb1 to
28de5aa
Compare
* Make virq_controller_init for the vGIC register the vGIC region with the appropriate callbacks using the library's API instead of hard-coding it in the fault handling code. * Don't use `BOARD_` defines, instead just use seL4 based defines since we eventually want the library to be Microkit agnostic. Still not satisfied with the vGIC/fault handling code, there's still lots of improvements to be made. Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
vgic_cleanup
branch
from
28de5aa to
f2ac03c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOARD_defines, instead just use seL4 based defines since we eventually want the library to be Microkit agnostic.Still not satisfied with the vGIC/fault handling code, there's still lots of improvements to be made.