Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkvirtdisk fixes + macos support #108

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

erichchan999
Copy link
Contributor

  • Added support for macOS. fdisk behaves differently there.
  • Added check for dosfstools needed for mkfs.fat
  • Specifies FAT12 for the filesystem in each partition, when previously it was using the default in mkfs.fat
  • Now handles the problem of beginning sector being either 1 or 2048 depending on the size of the disk (a restriction only in the linux case).
  • Added a check for minimum size in disk that would break either tool of fdisk or mkfs.fat.
  • Silence dd stderr. It seems to direct logging there, causing the zig build system Building virtio example with zig #65 to report an error.

Copy link
Collaborator

@Ivan-Velickovic Ivan-Velickovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🤌

@Ivan-Velickovic Ivan-Velickovic merged commit 0b63a7f into main Aug 7, 2024
8 checks passed
@Ivan-Velickovic Ivan-Velickovic deleted the mkvirtdisk_updates branch August 7, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants