Skip to content

Commit

Permalink
Remove unnecessary comments
Browse files Browse the repository at this point in the history
Signed-off-by: Ivan-Velickovic <[email protected]>
  • Loading branch information
Ivan-Velickovic committed Nov 20, 2024
1 parent 6ee407c commit 37fe8cc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
7 changes: 0 additions & 7 deletions examples/simple/vmm.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@
#include <libvmm/arch/aarch64/linux.h>
#include <libvmm/arch/aarch64/fault.h>

// @ivanv: ideally we would have none of these hardcoded values
// initrd, ram size come from the DTB
// We can probably add a node for the DTB addr and then use that.
// Part of the problem is that we might need multiple DTBs for the same example
// e.g one DTB for VMM one, one DTB for VMM two. we should be able to hide all
// of this in the build system to avoid doing any run-time DTB stuff.

/*
* As this is just an example, for simplicity we just make the size of the
* guest's "RAM" the same for all platforms. For just booting Linux with a
Expand Down
3 changes: 0 additions & 3 deletions include/libvmm/virq.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ bool virq_inject(size_t vcpu_id, int irq);
* passthrough access to a particular device on the hardware.
* After registering the passthrough IRQ, call `virq_handle_passthrough` when
* the IRQ has come through from seL4.
*
* @ivanv: currently this API assumes a Microkit environment. This should be changed
* if/when we make libvmm agnostic to the seL4 environment it is running in.
*/
bool virq_register_passthrough(size_t vcpu_id, size_t irq, microkit_channel irq_ch);
bool virq_handle_passthrough(microkit_channel irq_ch);

0 comments on commit 37fe8cc

Please sign in to comment.