Update usb-device #718
Merged
Update usb-device #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajattack
approved these changes
Jan 18, 2024
|
Looks like rustfmt is mad about the isochronous whitespace but otherwise LGTM |
ianrrees
force-pushed
the
update-usb-device
branch
from
443cd98 to
e1fb7ad
Compare
The usb-device upgrade is a breaking change for both usb-device and our HAL. This commit updates our tier 1 BSPs only.
ianrrees
force-pushed
the
update-usb-device
branch
from
e1fb7ad to
866436b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The usb-device crate is used by both the HAL and USB Class crates, to create a USB Device. The same version of usb-device needs to be used for all the dependencies of a firmware, which can lead to difficulty for instance if a required USB Class crate hasn't been updated.
This PR updates usb-device to the latest released version. This is a breaking change for both usb-device and our HAL.
This commit updates our tier 1 BSPs only.
(when we cut the usb-device 0.3.0 release, we forgot to include a new type in the prelude, which made it somewhat annoying to use - hence the 0.2 -> 0.3.1)
Checklist
CHANGELOG.mdfor the BSP or HAL updated#[allow]certain lints where reasonable, but ideally justify those with a short comment.