Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arduino_mkrzero: add blinky_rtic example #580

Closed
wants to merge 2 commits into from
Closed

arduino_mkrzero: add blinky_rtic example #580

wants to merge 2 commits into from

Conversation

arkap
Copy link

@arkap arkap commented Mar 15, 2022

Summary

Add a blinky_rtic example for arduino_mkrzero.

I've adapted the example from the feather_m0 board for the arduino_mkrzero board. It's currently throwing a lot of warnings because of the use of gpio::v1.

@@ -15,18 +15,24 @@ version = "0.7"
optional = true

[dependencies.atsamd-hal]
path = "../../hal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed. arduino_mkrzero is a Tier 2 board, so it should use a crates.io dependency to atsamd-hal rather than a path dependency.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove that line, the build fails with

the trait `Monotonic` is not implemented for `arduino_mkrzero::rtc::Rtc<arduino_mkrzero::rtc::Count32Mode>`

Does that mean upstream atsamd-hal needs to catch up? I don't quite understand what the issue is but if it's a matter of implementing Monotonic, I'd be happy to give it a try.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because the latest crates.io atsamd-hal version still has one of the 0.6.0-rc.x RTIC dependencies. Monotonic is implemented, but there's a version mismatch with you cortex-m-rtic = "1.0" dependency. You can either wait for atsamd-hal to catch up, which should hopefully happen soon, or match your RTIC version with the one from atsamd-hal.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's give atsamd-hal some time and wait. Thanks for the insight.

@TDHolmes
Copy link
Contributor

Another one waiting on #570

Copy link
Contributor

@TDHolmes TDHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make changes now that there has been a HAL release

@bradleyharden
Copy link
Contributor

@arkap, just pinging you about this, since #570 was merged.

@jbeaurivage jbeaurivage added the board support Related to support for a particular board label May 14, 2023
@johngigantic johngigantic mentioned this pull request Aug 17, 2023
3 tasks
@sajattack sajattack closed this Oct 2, 2023
@sajattack
Copy link
Member

Superceded by #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board support Related to support for a particular board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants