-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arduino_mkrzero: add blinky_rtic example #580
Conversation
Signed-off-by: Arne Kappen <[email protected]>
Signed-off-by: Arne Kappen <[email protected]>
@@ -15,18 +15,24 @@ version = "0.7" | |||
optional = true | |||
|
|||
[dependencies.atsamd-hal] | |||
path = "../../hal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed. arduino_mkrzero
is a Tier 2 board, so it should use a crates.io
dependency to atsamd-hal
rather than a path dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remove that line, the build fails with
the trait `Monotonic` is not implemented for `arduino_mkrzero::rtc::Rtc<arduino_mkrzero::rtc::Count32Mode>`
Does that mean upstream atsamd-hal
needs to catch up? I don't quite understand what the issue is but if it's a matter of implementing Monotonic
, I'd be happy to give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because the latest crates.io
atsamd-hal
version still has one of the 0.6.0-rc.x
RTIC dependencies. Monotonic
is implemented, but there's a version mismatch with you cortex-m-rtic = "1.0"
dependency. You can either wait for atsamd-hal to catch up, which should hopefully happen soon, or match your RTIC version with the one from atsamd-hal
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's give atsamd-hal some time and wait. Thanks for the insight.
Another one waiting on #570 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make changes now that there has been a HAL release
Superceded by #697 |
Summary
Add a blinky_rtic example for arduino_mkrzero.
I've adapted the example from the feather_m0 board for the arduino_mkrzero board. It's currently throwing a lot of warnings because of the use of
gpio::v1
.