Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enable/disable SOF interrupt in USB peripheral #398

Closed
wants to merge 1 commit into from

Conversation

henrikssn
Copy link
Contributor

@twitchyliquid64 I haven't tested it yet but is this inline with your suggestion?

@twitchyliquid64
Copy link
Contributor

Yepp!

We should be careful about testing it extensively, depending on the pecking order of the interrupts we may need to clear it in other places of poll() as well.

@ianrrees
Copy link
Contributor

Thanks for this! It's a really handy bit towards solving a problem I've been mulling over. What's the use case that prompted this initially?

I'm toying with a usb class implementation that is meant to do all its work in the poll() method, with an eye to making the bus own the class (per 2 here). One issue with that approach currently, is that the class doesn't have a way to notify when it wants attention from the bus.

Currently this change doesn't trigger poll() for each class, but it looks like a straightforward modification to usb-device could change that, or this could be a more permanent solution.

@jbeaurivage
Copy link
Contributor

Closing, as this was superseded by #456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants