Fix startup #45
Open
Fix startup #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till
commented
Jan 30, 2020
| msg: "minio_secret_key is set but must be at least 8 characters" | ||
| when: minio_secret_key|length < 8 and minio_secret_key|length != 0 | ||
|
|
||
| - name: Setup __minio_volumes (cluster context) |
There was a problem hiding this comment.
I moved the logic for this outside the template. So I could validate it.
till
commented
Jan 30, 2020
| @@ -20,7 +20,7 @@ Group={{ minio_group }} | |||
| PermissionsStartOnly=true | |||
|
|
|||
| EnvironmentFile={{ minio_server_envfile }} | |||
| ExecStartPre=/bin/bash -c "[ -n \"${MINIO_VOLUMES}\" ] || echo \"Variable MINIO_VOLUMES not set in {{ minio_server_envfile }}\"" | |||
| #ExecStartPre=/bin/bash -c "[ -n \"${MINIO_VOLUMES}\" ] || echo \"Variable MINIO_VOLUMES not set in {{ minio_server_envfile }}\"" | |||
There was a problem hiding this comment.
I can remove this if you like.
- "validates" key, secret and volumes - moves logic for volumes from template to preflight
- doesn't seem to be able to get the env vars on CentOS7 - seems like a known problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @atosatto! :)
I pushed some suggestions to improve startup, one of the things is validation of variables — I introduced a
preflight.ymlwith tasks to achieve this. Mostly becausefooandbaras access key and secret key didn't work, and I had to ssh into VMs to see this.Then the more important "fix" is the removal of your
ExecPreStart=. Again, I am using CentOS7 and the check failed consistently, though when commented out, Minio would find the variables from the defaults file and start. It seems like it's not possible to use environment variables like this. So I figured might as well do the validation in Ansible vs. the unit.Let me know what you think.