Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests on lambda_t, low sigma values and guided functions #80

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

kilianFatras
Copy link
Collaborator

What does this PR do?

I have added some tests on conditional flow matcher classes. Namely, I am now testing lambda_t, low sigma values and guided functions with return_noise.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e96c52c) 35.81% compared to head (3f08702) 35.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   35.81%   35.90%   +0.09%     
==========================================
  Files          67       67              
  Lines        7419     7419              
==========================================
+ Hits         2657     2664       +7     
+ Misses       4762     4755       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@kilianFatras kilianFatras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilianFatras kilianFatras merged commit 3c0cfdd into main Nov 30, 2023
33 checks passed
@kilianFatras kilianFatras deleted the add_tests branch December 14, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants