Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch 2.0 compatible with Torchdyn #61

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Torch 2.0 compatible with Torchdyn #61

merged 1 commit into from
Oct 3, 2023

Conversation

kilianFatras
Copy link
Collaborator

What does this PR do?

This PR updates the code base compatible with Torch2.0 and TorchDyn1.0.6.

Fixes #60

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kilianFatras kilianFatras requested a review from atong01 October 2, 2023 22:57
atong01
atong01 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@atong01 atong01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

torchdyn==1.0.3 --> torchdyn==1.0.6 changed how forward works and now requires *args and **kwargs. I will change this back in torchdyn==1.0.7, but this is good fix for now :)

@kilianFatras
Copy link
Collaborator Author

Should we wait for torchdyn 1.0.7 or at least put a memo to discard these changes when 1.0.7 is out?

@kilianFatras kilianFatras merged commit c520fb5 into main Oct 3, 2023
@kilianFatras kilianFatras deleted the correct_small_bugs branch November 2, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atong01 atong01 atong01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

troch 2.0 is not compatible with Torchdyn 1.0.6
2 participants
@kilianFatras @atong01