Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit batch size parameter for FID computation #110

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

QB3
Copy link
Contributor

@QB3 QB3 commented Mar 1, 2024

What does this PR do?

Add explicit batch size parameter for FID computation

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.92%. Comparing base (fa13e7c) to head (8074f56).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   35.92%   35.92%           
=======================================
  Files          67       67           
  Lines        7399     7399           
=======================================
  Hits         2658     2658           
  Misses       4741     4741           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atong01
Copy link
Owner

atong01 commented Mar 2, 2024

LGTM. Thanks!

@atong01 atong01 merged commit bcc5082 into atong01:main Mar 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants