Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

[WIP] Update to use {automation-client,sdm,sdm-core} 2.0 branches #32

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

XertroV
Copy link

@XertroV XertroV commented Jun 5, 2020

  • Mostly just updating deps and imports
  • will try to format imports and things like the rest of your codebase (here and PR for sdm-pack-build), too, since that should be mostly trivial (oh, and squash too)

Working on getting tests working; it looks like doWithFiles might have changed behaviour - particularly around files and dirs starting with .; and processes things in a different order, slightly.

TBH I'm not really confident I've got it, but results seem to match. I also moved one of the file description objs in the test, but I figured this isn't substantially changing anything so if it is a change in behaviour of doWithFiles this is okay.

TODO
  • Replace ProjectFile type which has been dropped from automation-client
  • Reformat imports to match existing style
  • Squash commits to match std format referenced in contributing.md
  • pass tests
  • check working with my SDM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant