Better clarify arrowType warning

atomiks · Oct 14, 2019 · a8506cd · a8506cd
1 parent b358552
commit a8506cd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/validation.ts b/src/validation.ts
@@ -107,9 +107,14 @@ export function validateProps(
       prop === 'arrowType',
       `The \`arrowType\` prop was removed in v5 in favor of overloading the
       \`arrow\` prop.
-  
+
+      "round" string was replaced with importing the string from the package.
+
+      * import {roundArrow} from 'tippy.js'; (ESM version)
+      * const {roundArrow} = tippy; (IIFE CDN version)
+
       Before: {arrow: true, arrowType: "round"}
-      After: {arrow: "round"}`,
+      After: {arrow: roundArrow}`,
     );
 
     warnWhen(

diff --git a/test/unit/validation.test.js b/test/unit/validation.test.js
@@ -74,10 +74,15 @@ describe('validateProps', () => {
     expect(spy).toHaveBeenCalledWith(
       ...getFormattedMessage(
         `The \`arrowType\` prop was removed in v5 in favor of overloading the
-      \`arrow\` prop.
-  
-      Before: {arrow: true, arrowType: "round"}
-      After: {arrow: "round"}`,
+        \`arrow\` prop.
+
+        "round" string was replaced with importing the string from the package.
+
+        * import {roundArrow} from 'tippy.js'; (ESM version)
+        * const {roundArrow} = tippy; (IIFE CDN version)
+
+        Before: {arrow: true, arrowType: "round"}
+        After: {arrow: roundArrow}`,
       ),
     );
   });