Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: embeddings and image generations inference services #205

Merged
merged 22 commits into from
Nov 11, 2024
Merged

feat: embeddings and image generations inference services #205

merged 22 commits into from
Nov 11, 2024

Conversation

francis2tm
Copy link
Collaborator

@francis2tm francis2tm commented Oct 30, 2024 •
edited
Loading

Fixes #181, #182 and #194

@francis2tm francis2tm self-assigned this Oct 30, 2024
jorgeantonio21
jorgeantonio21 reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

The comments I made to #198 apply to this PR as well, let's wait until #198 is merged and then we can merge this one as well.

@francis2tm francis2tm mentioned this pull request Nov 11, 2024
Closed
@francis2tm francis2tm changed the title feat: image generations server feat: embeddings and image generations inference services Nov 11, 2024
This was linked to issues Nov 11, 2024
feat: embeddings inference #182
Closed
chore: make atoma-node agnostic to backend #194
Closed
jorgeantonio21
jorgeantonio21 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
@jorgeantonio21 jorgeantonio21 merged commit 380a2b1 into main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeantonio21 jorgeantonio21 jorgeantonio21 approved these changes

Assignees

@francis2tm francis2tm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: make atoma-node agnostic to backend feat: embeddings inference feat: image generation inference
2 participants
@francis2tm @jorgeantonio21