-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stable diffusion #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good ! I left a few comments to be addressed before merging.
8f45df7
to
5cd6905
Compare
c531d5b
to
5e55a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a few comments !
atoma-inference/src/candle/mod.rs
Outdated
pub fn device() -> Result<Device, candle::Error> { | ||
if cuda_is_available() { | ||
info!("Using CUDA"); | ||
Device::new_cuda(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to initialize the Device
with ordinal = 0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's the first card in the system. So if we do plan to support multi-gpu system then we can add support for selecting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely allow for this, as this will be crucial to the network
No description provided.