This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 364
Rollup #1341
Draft
aminya
wants to merge
30
commits into
atom:master
Choose a base branch
from
aminya:rollup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rollup #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
rollup
branch
5 times, most recently
from
May 29, 2020 06:31
080dc4c
to
40fa59a
Compare
Coffeescript does not understand dynamic import in line 335 of treeview.coffee. We can use normal require and copy the file instead. |
aminya
force-pushed
the
rollup
branch
3 times, most recently
from
May 29, 2020 21:44
95d766b
to
7c873e9
Compare
ignored-names-importer
aminya
force-pushed
the
rollup
branch
7 times, most recently
from
May 30, 2020 01:22
be6e146
to
6ca4e04
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: specs call the individual files, which makes this hard.
Description of the Change
code:
rollup:
babel:
Benefits
This speeds up the loading of tree-view.
Possible Drawbacks
Needs special command for registering the package
Applicable Issues