Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Rollup #1341

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Rollup #1341

wants to merge 30 commits into from

Conversation

aminya
Copy link

@aminya aminya commented May 29, 2020

WIP: specs call the individual files, which makes this hard.

Description of the Change

code:

  • used modern import/exports
  • fixed some errors with calling @ before initiating super (to prevent errors)
  • used dynamic import for ignore-names (to prevent errors)
  • use normal for-loop in root-drag-drop (to prevent errors)

rollup:

  • Using rollup to bundle the javascript and CoffeeScript files together.

babel:

  • use babel plugin to build the import/exports

Benefits

This speeds up the loading of tree-view.

Possible Drawbacks

Needs special command for registering the package

npm install
npm run build
npm ppublish
apm publish minor

Applicable Issues

@aminya aminya force-pushed the rollup branch 5 times, most recently from 080dc4c to 40fa59a Compare May 29, 2020 06:31
@aminya aminya marked this pull request as draft May 29, 2020 07:00
@aminya
Copy link
Author

aminya commented May 29, 2020

Coffeescript does not understand dynamic import in line 335 of treeview.coffee. We can use normal require and copy the file instead.

@aminya aminya force-pushed the rollup branch 3 times, most recently from 95d766b to 7c873e9 Compare May 29, 2020 21:44
ignored-names-importer
@aminya aminya force-pushed the rollup branch 7 times, most recently from be6e146 to 6ca4e04 Compare May 30, 2020 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant