This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Ensure secret exists when tyring to read as text #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
#477
Description of the Change
Ensure the variable
secret
is not NULL before passing it to the functionsecret_value_get_text
.Alternate Designs
An alternate design could be to use a
GCancellable
object insecret_service_search_sync
function call. I tried to use it but failed to understand how to use it.Possible Drawbacks
This MR should not add a possible drawback.
Verification Process
Test suite still pass (
npm run test
).Using
FindCredentials
without unlocking my keystore in my electron app does not crash anymore.The error I got during my usage was:
Release Notes
Fixed a bug where calling
FindCredentials
without unlocking the keystore on Linux.