This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
[WIP] don't call method of destroyed webContents #2722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
The ubuntu tests have been failing, even for perfectly valid prs
One of the complained errors says "Attempting to call a function in a renderer window that has been closed or released."
EDIT: This appears in all the tests, so this error (or warning?) doesn't actually fail the tests
So I think this attempt removes the function call - and hopefully fixes the tests
Screenshot or Gif
Applicable Issues