Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#449 Testimonials redesign #609

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#449 Testimonials redesign #609

wants to merge 1 commit into from
+41 −32

Conversation

Ke-bean
Copy link
Contributor

@Ke-bean Ke-bean commented Oct 28, 2024 •
edited
Loading

PR Description

This PR is for redesigning the Testimonials page

Screen Shot 2024-11-22 at 08 29 47

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:18am

@Ke-bean Ke-bean self-assigned this Oct 29, 2024
aimedivin
aimedivin requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ke-bean, Remove that horizontal scroll bar and make sure translation for the testimonial section work as I was working before (it was fixed by @rwemakevin),
image

.github/workflows/tests runner.yml Outdated
@@ -23,7 +23,6 @@ jobs:
- name: Check linting errors
run: npm run lint
- name: Run tests and generate coverage reports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ke-bean , why is this run removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ke-bean , why is this run removed

Was testing something and forget to bring back it, now it's fixed @aimedivin

@Ke-bean
Copy link
Contributor Author

Ke-bean commented Oct 30, 2024 •
edited
Loading

@Ke-bean, Remove that horizontal scroll bar and make sure translation for the testimonial section work as I was working before (it was fixed by @rwemakevin), image

@Ke-bean , why is this run removed

Could you clarify which work you said you did before or @rwemakevin's work so that I can reference on what to change? @aimedivin

@aimedivin aimedivin linked an issue Oct 31, 2024 that may be closed by this pull request
Testimonials #449
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salim-54 Salim-54 Awaiting requested review from Salim-54

@hatfelicien hatfelicien Awaiting requested review from hatfelicien

@amiparadis250 amiparadis250 Awaiting requested review from amiparadis250

@aimedivin aimedivin Awaiting requested review from aimedivin

@Calebgisa72 Calebgisa72 Awaiting requested review from Calebgisa72

@elijahladdie elijahladdie Awaiting requested review from elijahladdie

Requested changes must be addressed to merge this pull request.

Assignees

@Ke-bean Ke-bean

Labels
Need Reviews Steppers Team Steppers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testimonials
3 participants
@Ke-bean @aimedivin @Salim-54