NONE: Clarify pull request rules #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagguh
approved these changes
Feb 13, 2020
| See the [existing issues](https://ecosystem.atlassian.net/projects/JPERF/issues/?filter=allissues) for things to start contributing. | ||
|
|
||
| ## Getting Your Pull Request Merged | ||
|
|
||
| All Pull Requests must be approved by at least one member of the @atlassian/jpt team |
There was a problem hiding this comment.
This is already explained and enforced by GitHub GUI.
There was a problem hiding this comment.
I usually read CONTRIBUTING.md before I start to write a code. GUI explains rules at the last phase of the contribution.
There was a problem hiding this comment.
You can read CODEOWNERS before writing code too. IMHO it's a micro-value, not worth denormalizing
|
|
||
| ### Pull Request Readiness readiness checklist | ||
|
|
||
| * [ ] Includes tests to exercise the new behavior and bugs. |
There was a problem hiding this comment.
Are these checkboxes supposed to be ticked? They're not tickable.
If we want to create a literal PR checklist, we can use a PR template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.