Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/jperf 1395 fix api dependencies #154

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Issue/jperf 1395 fix api dependencies #154

merged 2 commits into from
Oct 4, 2023

Conversation

pczuj
Copy link
Contributor

@pczuj pczuj commented Oct 4, 2023

No description provided.

@pczuj
Mark 3.23.0
22a9dbc
@pczuj
JPERF-1395 Confess javax.json dependency in API
1796b8c 
`com.atlassian.performance.tools.jiraactions.api.ActionType` depends on it in its constructor
and in its `deserialize` method.
@pczuj pczuj requested a review from a team as a code owner October 4, 2023 13:30
@pczuj
Copy link
Contributor Author

pczuj commented Oct 4, 2023

Without it I'd need to explicitly depend on the json-api to define own ActionType. Otherwise the compiler complains as I can't really use e.g. SearchJqlObservation.

@dagguh
Copy link
Contributor

dagguh commented Oct 4, 2023

Thanks for a nice commit message

@dagguh dagguh merged commit 7a4ff77 into master Oct 4, 2023
10 checks passed
@dagguh dagguh deleted the issue/JPERF-1395-fix-api-dependencies branch October 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagguh dagguh dagguh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pczuj @dagguh