New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid merging bucket tag into an array for histogram metrics #701

Merged

hstan merged 2 commits into master from htan/fix-histogram-bucket-tagg

Jun 14, 2024

Member

hstan commented Jun 14, 2024

Fix the issue that multiple histogram are sharing same tags - for historgrams even the resource attributes are the same the bucket tags are always different. For example, if a metric defines histogram buckets ["+Inf", "100"], the expected le tag for these 2 metrics are le:+Inf, le:100 respectively, not le:["+Inf", "100"]
Change the data point value type to float64 so it align with datadog backend data format


avoid merging bucket tag into an array for histogram metrics

50896db

hstan requested review from waynewu411, MovieStoreGuy and irisgve

June 14, 2024 00:02


fix test

4a12d77

irisgve approved these changes

View reviewed changes

waynewu411 approved these changes

View reviewed changes

hstan merged commit f5a9da6 into master

5 checks passed

hstan deleted the htan/fix-histogram-bucket-tagg branch

June 14, 2024 01:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment