-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISOC 3689 add git hub code scanning webhook #2314
ISOC 3689 add git hub code scanning webhook #2314
Conversation
03b14eb
to
03c57fa
Compare
One small thing to double check, for
I think |
Code scanning can be configured to trigger on push and pull requests to projected branches. So pushes to unprotected branches such as |
3bb165b
to
9bcde08
Compare
const cweId = tag.split(cwePrefix)[1].replace(/^0+/, ""); | ||
return { | ||
displayName: `CWE-${cweId}`, | ||
url: `https://cwe.mitre.org/cgi-bin/jumpmenu.cgi?id=${cweId}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between using this URL and https://cwe.mitre.org/data/definitions/${cweId}
?
The one you are using redirects to the data/definitions
page anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the URL https://cwe.mitre.org/ uses in their ID Lookup input. The difference is the error page when supplying an invalid ID. I suspect there is future-proof credence using the cgi
URL as it would be out in the wild and referenced in PDFs, hence the redirect.
9bcde08
to
2a62962
Compare
What's in this PR?
Adds Security in Jira
code_scanning_alert
webhook support. GitHub Security Code Scanning Alert webhooks will be transformed and submitted as Security Vulnerabilities in Jira.Vulnerabilities are only submitted from the default or protected branch. This is done by checking
When a Code Scan Alert is found in a PR, then merged into the default or protected branch, a webhook with the action
appeared_in_branch
is triggered with the same alert number, which is subsequently submitted to Jira.Remote Links will continue be handled in the same way.
Fixes an error where Code Scanning Alert Remote Link Webhook metrics were not being processed.
Why
Integrate GitHub with Security in Jira
https://hello.atlassian.net/wiki/spaces/CDX/pages/2673460294/RFC+GitHub+for+Jira+Security
Added feature flags
ENABLE_GITHUB_SECURITY_IN_JIRA
Affected issues
ISOC-3689
How has this been tested?
Locally
Unit Tests
Questions
We are emitting a new webhook metric for Code Scanning Alert Security Vulnerabilities (
code_scanning_alert_security
) in addition to the Remote Links handler. Does this make sense?