Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISOC-3776 Installation webhook handler #2307

Merged
merged 10 commits into from
Aug 6, 2023

Conversation

Harminder84
Copy link
Contributor

@Harminder84 Harminder84 commented Aug 2, 2023

What's in this PR?
Implemented installation webhook handler to check whether security permissions has been accepted or not. If yes, then

  • updateisSecurityPermissionsAccepted column in Subscriptions table to true
  • Submit request to Jira to link security workspace

Why
We are introducing new permissions to access dependabot_alerts and secret_scanning. Once these permissions are made available in the GH app, the GH Admin will need to accept them. We will use this data to track customers whose permission requests are still pending. Backfill for security VULNS will also be triggered on permission acceptance

Added feature flags
ENABLE_GITHUB_SECURITY_IN_JIRA

Affected issues
ISOC-3776

How has this been tested?
Unit test
Local

@Harminder84 Harminder84 requested a review from a team as a code owner August 2, 2023 23:53
Copy link
Contributor

@gxueatlassian gxueatlassian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅ to me, let me know once db scripts are ran for all env, then I can unblock this one.

@Harminder84
Copy link
Contributor Author

@gxueatlassian, I ran the DB scripts for all three environments.

@Harminder84 Harminder84 merged commit c2c689b into main Aug 6, 2023
3 of 4 checks passed
@Harminder84 Harminder84 deleted the ISOC-3776-installation-webhook branch August 6, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants