Fix for Terraform 1.10.0 #439
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2024 15:15
|
I saw the fix will be backported to 1.10, are we going to revert this change later? |
|
We can but we don't have to since this change just swaps env var for a var in tfvars file. |
yzha645
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Terraform has been upgraded to 10.1.0, our e2e started failing. For some reason, Terraform started treating TV_VAR_* variables differently.
So, instead of using
TF_VAR_ kinesis_log_producers_role_arns(which is a json) env var, it's used in the tfvars file template that e2e test use.Raised an issue upstream hashicorp/terraform#36134
Checklist