Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove javax.activation to fix verifyLicensing #25

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dagguh
Copy link
Contributor

@dagguh dagguh commented Jun 14, 2024

The javax.activation:activation license is not being found, for some reason.

BTW I tracked down the inclusion of javax.activation to old monorepo:

   /**
     * Necessary for JDKs, which no longer bundle java.xml.bind, e.g. Java 10.
     */
    private fun jaxb(): List<String> = listOf(
        "org.glassfish.jaxb:jaxb-runtime:2.3.0",
        "javax.activation:activation:1.1.1"
    )

Currently CI runs on Java 11, let's see if it's necessary.

Its license is hard to parse for some reason.
Maybe due to weird JAR contents.
@dagguh dagguh requested a review from a team as a code owner June 14, 2024 16:04
@dagguh
Copy link
Contributor Author

dagguh commented Jun 14, 2024

Welp, the CI is green. Of course there might be cases where the lack of javax.activation throws a NoClassDefFoundError. This would mean the test coverage here didn't catch it. Any bug discovered like that is a trigger to improve coverage. Better to move on than to be afraid of every change. The consumers can always revert back to the previous version.

@dagguh dagguh enabled auto-merge (rebase) June 14, 2024 16:21
@dagguh dagguh disabled auto-merge June 14, 2024 16:21
@dagguh dagguh merged commit 547635d into master Jun 14, 2024
3 checks passed
@dagguh dagguh deleted the fix-verify-licensing branch June 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant