Add permissions for managing s3 bucket policies and lifecycle configurations #16
Conversation
There was a problem hiding this comment.
Could you amend commit message and explain why it's needed?
In other words follow
https://cbea.ms/git-commit/#why-not-how
and move add the explanation from PR to commit itself - as it's something easily accessible in the code, while PR will get lost
…rations. The JPT-dev role needs these extra permissions to allow attaching a policy to a bucket and to create a lifecycle rule to automatically clean the bucket contents. These permissions are required when setting the jiraSharedStorageConfig option in DataCenterFormula (in aws-infrastructure) to store avatar and/or attachments in an S3 bucket (instead of the shared home).
MatthewCochrane
force-pushed
the
fsm-s3-permissions
branch
from
160543a
to
adfc013
Compare
Sure thing. Updated! |
Then this change should have happened in aws-infrastructure. Keep it local |
The code in this PR into aws-infrastructure which adds parameters to DataCenterFormula to store avatar and/or attachment data in an S3 bucket (instead of the shared home) requires that the
JPT-devrole gets these extra permissions to allow attaching a policy to a bucket and to create a lifecycle rule to automatically clean the bucket contents.