[DCA11Y-1145] Node version manager support #4
Conversation
...ugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/AbstractFrontendMojo.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java
Outdated
Show resolved
Hide resolved
...nd-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/GlobalCache.java
Outdated
Show resolved
Hide resolved
...d-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NPMInstaller.java
Show resolved
Hide resolved
.../java/com/github/eirslett/maven/plugins/frontend/lib/version/manager/VersionManagerType.java
Outdated
Show resolved
Hide resolved
|
I think I'd rather we get feature complete now so we can do one QA demo to rule them all. I'm thinking in the QA demo we check;
I can't think of anything else right now |
|
Perhaps a good development loop is to set yourself up some docker containers, one for each version manager? Maybe you already having something working for you |
|
One case I'm not sure about yet is no version file is specified and a version of Node is specified in the POM. I'm tempted to say we should do the vanilla behaviour and download it ourselves. We tell the users that the file is missing and they probably should create it. This offers a simple way to drop-in this fork as a replacement in situations where they haven't previously created the files. That's because we'll have other features like incremental compilation which we want them to adopt. |
- fix fnm when multiple node versions installed - use fnm dir to get installed node - disable tests on windows - fix paths in tests setup
|
I have skipped the new tests on windows, for now I'll assume we don't support windows. I'll revisit it later |
… of version provided to fmp
|
QA Demo note: test on a project with split node installation in root and npm execution in modules |
* DCA11Y-1145: handle empty SHELL * DCA11Y-1145: handle empty SHELL * DCA11Y-1145: handle empty SHELL * DCA11Y-1145: chore: prepare for releaes of 1.15.0-atlassian-1-bd74da96 * DCA11Y-1145: chore: clean up release * DCA11Y-1145: fix: fall back on reading $SHELL from bin/sh
* DCA11Y-1145: fix: call fnm directly * DCA11Y-1145: fix: get absolute path of execs * DCA11Y-1145: chore: try with bashrc * DCA11Y-1145: chore: try with env var for multishells * DCA11Y-1145: chore: fnm dir needs to be basedir * DCA11Y-1145: chore: fnm dir needs to be non existing dir * DCA11Y-1145: clean up * DCA11Y-1145: remove test that can't be set
…ger-support # Conflicts: # frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java # frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndPnpmMojo.java # frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndYarnMojo.java # frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/WebpackMojo.java # frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NPMInstaller.java # frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java # frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionHelper.java
Changes: