Fixed Energy.toString and mandatory parquet value omission
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, a lower energy value was printed in KJoule and a higher one in Joule. This change reverses it. Before this change no exception was thrown when omitting value in a required parquet field while exporting, resulting in unreadable parquet file. Now exception is thrown while exporting.
T0mexX
changed the title
Energy.toString and mandatory parquet value omission
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
============================================
- Coverage 61.13% 61.11% -0.02%
Complexity 2143 2143
============================================
Files 395 395
Lines 11518 11521 +3
Branches 1179 1180 +1
============================================
Hits 7041 7041
- Misses 4144 4147 +3
Partials 333 333 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this change, a lower energy value was printed in KJoule and a higher one in Joule. This change reverses it.
Before this change, no exception was thrown when omitting a value in a required parquet field while exporting, resulting in an unreadable parquet file (IDK why the library does not detect this). Now, an exception is thrown as soon as a required value is omitted in one row.
Implementation Notes ⚒️
N/A
External Dependencies 🍀
N/A
Breaking API Changes⚠️
N/A