Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Widget Support #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Illusion47586
Copy link

Description

Added the functionality to use custom widgets in place of Capture, Toggle, Confirm and Cancel buttons.
Also added documentation regarding the same.

param type default value
captureWidget Widget null
cameraToggleWidget Widget null
confirmWidget Widget null
cancelWidget Widget null

Fixes issue:

  • Give developers option to use custom buttons.. Fixes #4

Screenshots

Screenshot_2021-04-09-01-31-20-725_com atlan darwin_camera_example
Screenshot_2021-04-09-01-31-26-152_com atlan darwin_camera_example

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

There were no breaking changes, just ran the normal tests given in the project, and it passed.

Added custom widget support for cancel, capture, toggle and confirm button.
Copy link
Contributor

@askprateek askprateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ishaan1995 Can you compile and test it once?

@Illusion47586
Copy link
Author

Any update?

@askprateek
Copy link
Contributor

askprateek commented May 19, 2021

Hey @Illusion47586,

We will recommend you install this plugin directly from Github. Right now we don't have access to our publisher email hence we won't be able to push the changes on pub.dev.

Copy link
Contributor

@askprateek askprateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Illusion47586
Copy link
Author

Alright, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give developers option to use custom buttons.
2 participants