Fix passing resolution argument to ghostscript in lattice parser #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 13 13
Lines 1511 1511
Branches 349 349
=======================================
Hits 1325 1325
Misses 129 129
Partials 57 57
Continue to review full report at Codecov.
|
|
Hey! As camelot-dev/camelot#343, we try to build a maintained fork at pypdf_table_extraction. Do you want to open the PR against that branch so that we can merge your improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lattice parser has a resolution attribute that is never used. A default value of 300 is instead passed to ghostscript.
I changed the ghostscript command to use
self.resolutionas it was intended.