Consul cache background update #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CptnSnail
reviewed
Nov 14, 2023
Ba-Ski
reviewed
Nov 14, 2023
Ba-Ski
reviewed
Nov 14, 2023
CptnSnail
approved these changes
Nov 14, 2023
Ba-Ski
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes long wait time for resolving address using
ConsulServiceAddressin some situations.Added metrics for consul request.
Details
In situations when Consul response time increases:
Previously
ConsulServiceAddressawaited consul for response if cache update is in process. It produced situation when all request to other service were blocked until Consul response returned. Situation repeats each cache update(default 5 sec).Cache clears itself in case of error response from consul, next requests will be resolved with error "Не удалось взять настройки из консула для service:environment", until success cache update occures.
Now
ConsulServiceAddressalways resolves service address from cache. Warning: Cache will not be changed in case consul returns error response, next requests use potentially outdated cache.