-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on information_schema for MyXQL driver #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to review, I left you a comment, and I still need to test it manually on my side, to be sure backwards compatibility is maintained.
Thank you for taking the time reviewing the change set. As you may anticipate it, getting rid of the tenants table might be a breaking change for some that needs to be reflected on the repo mix versioning. |
Yeah, but I think we could make it backward compatible by rollbacking the |
Rolling back most of the changes to keep alignment with the tenants table, while using
|
After a quick thought about compatibility and for safer merge, I am setting the default behavior to work with the If anyone (like me) wishes to not work with
|
Pretty cool! Awesome work, thanks! And sorry for all the back and forth. Merging it to master, will release a new version of triplex with your changes soon. |
@HammamSamara one last request: could you open a new PR changing the default behavior to use the information schema? I think that's a sane default as it's simpler than having to add a new table. We will then release that other one on 2.0 |
PR opened here #81 |
This pull request remove the dependency on the tenants table in favor of the existing
information_schema.schemata
table, which brings MySQL tenancy creation flow closer to the postgres flow.