-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new concept doc (application) #992
docs: new concept doc (application) #992
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-992--asyncapi-website.netlify.app/ |
@derberg Should I change the mermaid diagram to be Preview link: |
@fmvilas pingy pongo? 😂😄😬✌🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 👏🏼
one comment we need to discuss
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Heyooo @derberg, sorry if I accidentally ask you to repeat yourself 😂 What else do I need to do on this doc? (I accepted your commit suggestions and I understood why going into Channel bindings was too much too soon. I just now felt confused about what else I should address in this PR 😅 ) Should I perhaps add a sentence like this?
thank you for the feedback so far!! |
it looks good I'm only thinking that we should extend this doc and also talk about we could add section where we would write:
makes sense? inspired by https://www.asyncapi.com/blog/publish-subscribe-semantics also pinging all maintainers of the spec: @smoya @fmvilas @dalelane @char0n as all concept docs relate to spec 💯 and they should be aware and be able to suggest changes if needed |
@derberg 🚨 FYI, I want to merge this AT THE SAME TIME as when we merge @nelsonmic's I don't mind waiting for his to be approved. |
@alequetzalli ok /dnm and you just merge whenever you want |
well no, I can't merge this myself because I can't merge my own PRs 😂😜 I will still need you or someone to merge it when it's time to merge nelson's protocol doc |
@alequetzalli fair point, makes sense 🤣 just ping me when you need to merge it 😄 |
yo, you forgot to merge these PRs @derberg .. remember you are to merge the protocol and application docs together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @alequetzalli, I made a couple of changes in other files also to avoid creating a new PR and requesting for approvals. They are just made to align the UpNext and GoBack buttons correctly. Anything from your side @derberg?
/rtm |
folks, I'm changing settings for this PR so I can merge as admin. There is no other way, because for now except for readme @alequetzalli is the only codeowner for markdown files, together with the bot. |
thanks for helping us merge these!! |
yo @akshatnema , you messed up my order here.. O_O I intentionally wanted the There is a reason I teamed with Lukasz and had us wait to merge my The next time you want to make a change, don't assume. Please ask first via a commit suggestion. |
@alequetzalli If you look into the changes made in the commit The order you see here is determined using the metadata of the Doc pages created inside the categories specified there. So, you probably have to change |
yeah, @alequetzalli I actually approved @akshatnema change as for me, it also looked weird that buttons do not match the nav order, so my brain assumed it must be wrong 🤷🏼 and because I promised to merge both at the same time, we did it the best we can. |
This resolves #976