fix: navbar button size #3529
fix: navbar button size #3529
Conversation
AayushhGoyal
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 668 668
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3529--asyncapi-website.netlify.app/ |
|
@sambhavgupta0705 can you please check it |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/CaseStudyCard.tsx (1)
26-26: Hover scaling effect could benefit from reduced transition duration to improve subtlety.
Hover scaling is a nice interactive touch, but consider a shorter transition duration (e.g.,duration-150) to reduce any perceived jumpiness.- className=" flex h-[315px] max-w-sm flex-col items-center justify-center overflow-hidden rounded-md border border-gray-400 bg-white p-4 shadow-xl duration-200 hover:scale-105" + className=" flex h-[315px] max-w-sm flex-col items-center justify-center overflow-hidden rounded-md border border-gray-400 bg-white p-4 shadow-xl duration-150 hover:scale-105"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/CaseStudyCard.tsx(1 hunks)
🔇 Additional comments (2)
components/CaseStudyCard.tsx (2)
22-22: Great use of Tailwind utilities to handle layout and spacing.
This makes the container more responsive and easier to maintain.
32-32: Confirm browser support for the text-balance utility.
If text-balance relies on a newer Tailwind or a custom utility with limited browser support, ensure it degrades gracefully. Otherwise, it’s a neat addition for readability.
✅ Verification successful
The previous search showed that text-balance is only used once in the codebase. Let's check the Tailwind configuration and version to understand if this is a built-in utility or custom configuration, which will help determine browser support.
The text-balance utility is safe to use with good browser support
The codebase is using Tailwind CSS v3.4.3, which includes the text-balance utility as part of its core features. This utility is based on the CSS text-wrap: balance property, which has good browser support in modern browsers (Chrome 114+, Firefox 119+, Safari 16.5+). For older browsers, it gracefully degrades to normal text wrapping without any layout issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Searching if 'text-balance' is documented or used across the codebase.
rg --hidden --no-heading 'text-balance'
Length of output: 156
Script:
#!/bin/bash
# Check tailwind config for text-balance utility
fd -e js -e ts -e json "tailwind.config" -x cat {}
# Check package.json for tailwind version
cat package.json | jq '.dependencies["tailwindcss"], .devDependencies["tailwindcss"]'
Length of output: 5901
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/navigation/NavBar.tsx (1)
242-242: Ensure the button styling is consistent with brand-wide design guidelines.The use of Tailwind classes for responsive sizing here is good. For a more scalable solution, consider centralizing commonly used widths and text sizes in a shared config or pattern. This can help keep styles consistent across the site if you create additional buttons or revise the design in the future.
|
@AayushhGoyal Kindly go through the contributing guidelines at https://github.com/asyncapi/website/blob/master/CONTRIBUTING.md Ideally, we want contributors to create an issue and wait for a triage before creating PR. That would in fact save time for you as a contributor in case we don't want an issue to be fixed/prioritized as of now. |
Description
Related issue(s)
Fixes: #3528
ScreenShot
Summary by CodeRabbit