fix: #3496 text misalignment and unusual height reduction on hovering over boxes #3497

Utkarsh-123github · 2024-12-20T05:35:55Z

Description

fix : A bug fix
description : This PR basically resolves the issue of text misalignment and unusual height reduction on hovering over boxes.
For reference , video is attached :

Screen.Recording.2024-12-20.110304.mp4

Related issue(s)
Resolves #3496

Summary by CodeRabbit

Style
- Enhanced readability of class names in the Asyncapi3IdAndAddressComparison component by adjusting spacing.

coderabbitai · 2024-12-20T05:36:04Z

Walkthrough

The pull request involves minor formatting changes in the Asyncapi3IdAndAddressComparison component. Specifically, spaces were added to class name strings when evaluating hover states for paths and path items. These modifications are purely cosmetic and do not impact the component's core functionality or logic.

Changes

File	Change Summary
`components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx`	Added spaces in class name concatenation for `hoverState.Paths` and `hoverState.PathItem` conditions

Assessment against linked issues

Objective	Addressed	Explanation
Prevent height reduction on hover [#3496]	❓	Unable to determine from this change if the layout issue is resolved

Suggested labels

ready-to-merge

Suggested reviewers

derberg
magicmatatjahu
sambhavgupta0705
anshgoyalevil

Poem

🐰 A rabbit's tale of spacing neat,
Where classes dance with whitespace sweet
No logic changed, just visual grace
A tiny tweak in coding's embrace
Hover on, dear components bright! 🎨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4abdd82 and 9cfa3cf.

📒 Files selected for processing (1)

components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

netlify · 2024-12-20T05:36:14Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`9cfa3cf`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/67664069b72e070008c24fc4
😎 Deploy Preview	https://deploy-preview-3497--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-12-20T05:38:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (9c1fda0) to head (9cfa3cf).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3497   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files          21       21           
  Lines         664      664           
=======================================
  Hits          575      575           
  Misses         89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asyncapi-bot · 2024-12-20T05:39:22Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	46
🟢 Accessibility	98
🟢 Best practices	92
🟢 SEO	100
🔴 PWA	33

Lighthouse ran on https://deploy-preview-3497--asyncapi-website.netlify.app/

anshgoyalevil

Thanks @Utkarsh-123github LGTM!

anshgoyalevil · 2024-12-21T14:33:05Z

/rtm

Utkarsh-123github · 2024-12-22T03:07:09Z

Thanks @anshgoyalevil for the review 🚀

Utkarsh-123github requested review from derberg, akshatnema, magicmatatjahu, anshgoyalevil, Mayaleeeee and asyncapi-bot-eve as code owners December 20, 2024 05:35

github-actions bot reviewed Dec 20, 2024

View reviewed changes

Utkarsh-123github changed the title ~~Fix #3496 text misalignment on hovering over boxes~~ fix : #3496 text misalignment and unusual height reduction on hovering over boxes Dec 20, 2024

Utkarsh-123github changed the title ~~fix : #3496 text misalignment and unusual height reduction on hovering over boxes~~ fix: #3496 text misalignment and unusual height reduction on hovering over boxes Dec 20, 2024

Fix asyncapi#3496 text misalignment on hovering over boxes

9cfa3cf

Utkarsh-123github force-pushed the fix-hover-bug branch from 4abdd82 to 9cfa3cf Compare December 21, 2024 04:13

asyncapi-bot requested review from devilkiller-ag and sambhavgupta0705 December 21, 2024 04:13

anshgoyalevil approved these changes Dec 21, 2024

View reviewed changes

asyncapi-bot added the ready-to-merge label Dec 21, 2024

asyncapi-bot merged commit f0969e2 into asyncapi:master Dec 21, 2024
22 checks passed

coderabbitai bot mentioned this pull request Dec 21, 2024

fix: resolved calender button render issue #3466

Merged

This was referenced Dec 22, 2024

changed columns from 3 to 2,added vertical spacing in mobile view #3511

Closed

Solved Testimonial alignment issue #3509 #3510

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: #3496 text misalignment and unusual height reduction on hovering over boxes #3497

fix: #3496 text misalignment and unusual height reduction on hovering over boxes #3497

Utkarsh-123github commented Dec 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 20, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot left a comment

netlify bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

asyncapi-bot commented Dec 20, 2024 •

edited

Loading

anshgoyalevil left a comment

anshgoyalevil commented Dec 21, 2024

Utkarsh-123github commented Dec 22, 2024

fix: #3496 text misalignment and unusual height reduction on hovering over boxes #3497

fix: #3496 text misalignment and unusual height reduction on hovering over boxes #3497

Conversation

Utkarsh-123github commented Dec 20, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Dec 20, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot left a comment

Choose a reason for hiding this comment

netlify bot commented Dec 20, 2024 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

codecov bot commented Dec 20, 2024 • edited Loading

Codecov Report

asyncapi-bot commented Dec 20, 2024 • edited Loading

anshgoyalevil left a comment

Choose a reason for hiding this comment

anshgoyalevil commented Dec 21, 2024

Utkarsh-123github commented Dec 22, 2024

Utkarsh-123github commented Dec 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 20, 2024 •

edited

Loading

netlify bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

asyncapi-bot commented Dec 20, 2024 •

edited

Loading