chore: update finance info for Sept and Oct #3408
Conversation
derberg
requested review from
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes involve modifications to the Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3408 +/- ##
=======================================
Coverage 67.77% 67.77%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 450 450
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3408--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
config/finance/2024/Expenses.yml (1)
Line range hint
1-108: Consider adding schema validationWhile the file maintains good structure, consider adding a YAML schema to validate:
- Required monthly categories
- Amount format (consistent decimals)
- Reasonable amount ranges based on historical data
This would help catch potential issues during the PR review process.
Would you like assistance in creating a JSON Schema for this YAML file?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
config/finance/2024/Expenses.yml(1 hunks)
🔇 Additional comments (2)
config/finance/2024/Expenses.yml (2)
98-98: LGTM: Formatting is consistent
The newline after the amount maintains consistent formatting with other entries.
104-108: Verify completeness of October entries
Similar to September, several typically recurring categories appear to be missing for October:
- JSON Schema Sponsorship (usually $250)
- Community Manager (usually $2000)
- Community Marketing Specialist (usually $2000)
Consider implementing automated validation to ensure all required monthly categories are present. This could help prevent accidental omissions in future updates.
| September: | ||
| - Category: Bounty Program | ||
| Amount: '3000.00' |
There was a problem hiding this comment.
don't worry about a spike, it is not a mistake, it's just that Q4 bounty got much more visibility from maintainers (plus some Q3 payouts), I think the amount will increase with each bounty Q so more and more maintainers use it regularly to get some funding or get some work on the project done.
cc @aeworxet
| @@ -87,12 +87,36 @@ August: | |||
| - Category: Community Manager | |||
| Amount: '2000.00' | |||
| - Category: Bounty Program | |||
| Amount: '1600.00' | |||
| Amount: '1800.00' | |||
There was a problem hiding this comment.
fixing wrong calculation
|
@derberg Are you waiting for someone? 😅 |
|
@akshatnema yeah triage, approval and merge, typical stuff 😛 |
There was a problem hiding this comment.
I believe on you @derberg , hence approving without review 😅
|
/rtm |
usual update of data to have transparent aggregated view at https://www.asyncapi.com/finance
Summary by CodeRabbit