Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrated index pages of website #2905

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

akshatnema
Copy link
Member

@akshatnema akshatnema commented Apr 24, 2024

Description

  • Migrated index page of the website.
  • Changed react-typing-animation to react-typist-component

Related issue(s)

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7cccecf
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/662b7411d8a39a0008c2770c
😎 Deploy Preview https://deploy-preview-2905--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akshatnema akshatnema marked this pull request as ready for review April 25, 2024 13:50
@anshgoyalevil
Copy link
Member

Some inconsistencies exist between the deployed render and npm run dev render.

For example:

Upcoming events are visible locally, but not on Netlify Deploy URL.

image


The &slash or &sol is being decoded to / locally (inside the DemoAnimation) but not on Netlify Deploy URL.


Links like (in netlify deployed version)
image
image

are looking different locally (localhost:3000)
image
image

@akshatnema
Copy link
Member Author

@anshgoyalevil very confusing why it isn't showing, although it's showing under production website locally.

@akshatnema
Copy link
Member Author

@anshgoyalevil Got the error, staticHelpers file is not converted to ts yet. Hence, it is not compiled in netlify.

@anshgoyalevil
Copy link
Member

@anshgoyalevil Got the error, staticHelpers file is not converted to ts yet. Hence, it is not compiled in netlify.

Can't we use js with ts simultaneously? I think js is transpiled with ts code to the .next directory.

Willing to migrate staticHelpers in this PR, or should we ask another contributor to do that in a separate PR?

@akshatnema
Copy link
Member Author

Willing to migrate staticHelpers in this PR, or should we ask another contributor to do that in a separate PR?

I'm doing it in this PR only.

@anshgoyalevil
Copy link
Member

Upcoming Events are still not visible on the homepage. Not showing in production site locally too 🚧

@akshatnema
Copy link
Member Author

akshatnema commented Apr 26, 2024

Upcoming Events are still not visible on the homepage. Not showing in production site locally too 🚧

At the runtime of the website, calendar data is not fetched in realtime. It is rendered from the pre-fetched meetings.json file.

Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 2b32ecd into asyncapi:migrate-ts Apr 26, 2024
14 checks passed
@akshatnema akshatnema deleted the migrate-index branch October 11, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants