Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the url rendering and OG tag issue #2866

Closed
wants to merge 23 commits into from

Conversation

sambhavgupta0705
Copy link
Member

@sambhavgupta0705 sambhavgupta0705 commented Apr 12, 2024

This pr fixes #2639

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5190dd7
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/664b9f570da9670008d17780

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Apr 14, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2866--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member Author

@akshatnema The incorrect URL rendering has been resolved in this PR.
We were not using the correct code line which is for NEXTJS which has been corrected in this PR

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Apr 15, 2024
@akshatnema
Copy link
Member

@sambhavgupta0705 I can't see the proper meta tags and HTML inside the page source of the deployed URL. Kindly analyze the root cause of the issue again.

@sambhavgupta0705
Copy link
Member Author

@akshatnema PTAL

@akshatnema
Copy link
Member

image

Proper meta tags are not shown according to the page viewed on the website.

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Apr 26, 2024

@akshatnema
I think the tags are there but the html content is not there.
So basically it is an error with hydration and i18next package.

One solution we can have is to pass the custom component

@akshatnema
Copy link
Member

I think the tags are there but the html content is not there.

Tags that are shown are not specific with every page. It is a static head component that is passed for every page. Hence, og:title, og:description are not changed according to different pages of the website.

@sambhavgupta0705
Copy link
Member Author

Ohkk got it

@sambhavgupta0705
Copy link
Member Author

Requesting an extension of 2 weeks more as I am busy with my intern project for now

@aeworxet aeworxet removed the bounty AsyncAPI Bounty program related label label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenGraph meta tags are not rendered and when rendered, URLs are wrong
4 participants