feat: migrate case studies #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishvamsinh28
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
akshatnema
requested changes
Apr 11, 2024
components/MDX.tsx
Outdated
| @@ -148,7 +148,7 @@ function CodeComponent({ children, className = '', metastring = '', ...rest }: C | |||
| caption={caption} | |||
| className={`${className || ''} rounded`} | |||
| language={language} | |||
| showLineNumbers={children.split('\n').length > 2} | |||
| showLineNumbers={children && typeof children === 'string' && children.split('\n').length > 2 ? true : undefined} | |||
I can see that Code component is not rendered correctly. |
|
@akshatnema @anshgoyalevil code component issue fixed |
sambhavgupta0705
suggested changes
Apr 18, 2024
|
@sambhavgupta0705 Done |
akshatnema
requested changes
Apr 19, 2024
components/MDX.tsx
Outdated
Comment on lines
261
to
263
| pre: (props: React.HTMLProps<HTMLPreElement>) => { | ||
| return CodeComponent((props.children as React.ReactElement)?.props); | ||
| }, |
There was a problem hiding this comment.
Instead of using return in block, directly return the CodeComponent using arrow function.
akshatnema
requested changes
Apr 19, 2024
|
@akshatnema css issue fixed |
akshatnema
reviewed
Apr 23, 2024
components/MDX.tsx
Outdated
Comment on lines
261
to
263
| pre: (props: React.HTMLProps<HTMLPreElement>) => { | ||
| return CodeComponent((props.children as React.ReactElement)?.props); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| pre: (props: React.HTMLProps<HTMLPreElement>) => { | |
| return CodeComponent((props.children as React.ReactElement)?.props); | |
| }, | |
| pre: (props: React.HTMLProps<HTMLPreElement>) => CodeComponent((props.children as React.ReactElement)?.props), |
There was a problem hiding this comment.
I actually made this change but why it wasn't included in the commit 🤔 lemme push changes again
asyncapi-bot
requested review from
BhaswatiRoy,
J0SAL,
octonawish-akcodes,
TRohit20 and
VaishnaviNandakumar
akshatnema
approved these changes
Apr 24, 2024
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrated case studies