Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding content about adding operations #2403

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

BhaswatiRoy
Copy link
Collaborator

Fix: #1512

Content:

Meaning of operations
Steps for adding operations
Types of operations
Work: GSoD 2023 Issue

Continuation: #2171

The previous pull request was closed due to release of spec v3

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b0b4e7f
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6579d3eebe6f5e00084726b9
😎 Deploy Preview https://deploy-preview-2403--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 7, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2403--asyncapi-website.netlify.app/

@BhaswatiRoy BhaswatiRoy changed the title adding content about adding operations docs: adding content about adding operations Dec 7, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli hey there, same like with others. A lot of edits that I need to you have a look at before you merge.

In general I feel that after we are done and all PRs are merged, you need another "cleanup" review, like titles, order, and probably add more cross linking

because for example in this document I would normally add info at the bottom that to understand traits field in operation people should read traits document, and in case of tags, tags document, same about bindings

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Dec 13, 2023

I am reviewing all titles and order in this same PR, I def am not waiting around for future PRs to do that 😂😄✌🏽

That said, I DO plan to open a future PR to add cross linking just as you mentioned; it's just easier to merge all the new pages and then do a single cross linking PR when all the pages get merged first. @derberg

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a309e91 into asyncapi:master Dec 13, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: document adding operations
4 participants