-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding content about adding operations #2403
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2403--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli hey there, same like with others. A lot of edits that I need to you have a look at before you merge.
In general I feel that after we are done and all PRs are merged, you need another "cleanup" review, like titles, order, and probably add more cross linking
because for example in this document I would normally add info at the bottom that to understand traits
field in operation
people should read traits document, and in case of tags, tags document, same about bindings
I am reviewing all titles and order in this same PR, I def am not waiting around for future PRs to do that 😂😄✌🏽 That said, I DO plan to open a future PR to add cross linking just as you mentioned; it's just easier to merge all the new pages and then do a single cross linking PR when all the pages get merged first. @derberg |
Co-authored-by: Alejandra Quetzalli <[email protected]>
Co-authored-by: Alejandra Quetzalli <[email protected]>
/rtm |
Fix: #1512
Content:
Meaning of operations
Steps for adding operations
Types of operations
Work: GSoD 2023 Issue
Continuation: #2171
The previous pull request was closed due to release of spec v3