fix: single backtick rendering as a codeblock in casestudies #2208
Conversation
karthikmurakonda
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2208--asyncapi-website.netlify.app/ |
karthikmurakonda
force-pushed
the
master
branch
from
74eba3d to
11319e2
Compare
|
Looks Good to me. @derberg Can you have a look, if we are missing out some MDX somewhere? |
|
@akshatnema, can I get the Hacktoberfest accepted label? If everything is alright... |
There was a problem hiding this comment.
all good from my side
most important the fix is done in https://deploy-preview-2208--asyncapi-website.netlify.app/casestudies/adeogroup
@karthikmurakonda thanks so much for the fix!
derberg
added
the
hacktoberfest-accepted
|
@akshatnema your approval is also necessary as in past you requested changes |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2208--asyncapi-website.netlify.app/ |
|
/rtm |
Description
Because of MDX v2 breaking changes here, there is no difference between single backtick(
inlineCodeis no more present) and triple backtick in the jsx output. Both give<code>tag as shown hereI followed their migration guide to place codeblock component on seeing the
pretag itself.Related issue(s)
Fixes #2188